Termux RUN_COMMAND: Robustere Dispatch‑Logik und detailliertes Logging#104
Open
Android-PowerUser wants to merge 8 commits into
Open
Termux RUN_COMMAND: Robustere Dispatch‑Logik und detailliertes Logging#104Android-PowerUser wants to merge 8 commits into
Android-PowerUser wants to merge 8 commits into
Conversation
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR successfully implements robust dispatch logic and comprehensive logging for Termux command execution. The changes enhance reliability through early validation, service verification, and clear error differentiation. The code is well-structured and maintains consistency with the existing codebase. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Termux("command")-Ausführung konnte in manchen Umgebungen fehlschlagen ohne ausreichende Diagnoseinformationen, weshalb das Verhalten robuster gemacht und besser geloggt werden muss.Description
executeTermuxCommandvalidiert jetzt das übergebene Kommando durchtrim()und bricht bei leerer Eingabe ab, um unnötige Dispatch‑Versuche zu vermeiden.RunCommandService-Klasse viaPackageManager.resolveService(...)überprüft und das gefundene Service‑Info im Log ausgegeben, damit fehlkonfigurierte Termux-Installationen früher erkannt werden können.com.termux.RUN_COMMANDverwendet nun die bereinigten Argumente, setzt zusätzlichcom.termux.RUN_COMMAND_RUNNER = "app-shell"und protokolliert die wichtigsten Extras (Pfad, Workdir, Background-Flag, Runner und Argumentenzahl) vor dem Dispatch.SecurityExceptionwird gesondert geloggt mit einem Hinweis auf fehlende Berechtigungen, und bei allen Fehlern wirdTermuxFeedbackPreferences.markTermuxNotFound(...)aufgerufen, um das Feedback‑Verhalten beizubehalten.Testing
./gradlew :app:compileDebugKotlin :app:testDebugUnitTest --tests com.google.ai.sample.util.CommandParserTest.Codex Task